Please update the pull request description to describe the changes in this patch.

Will this case be covered by the end-to-end docker tests?

Should I better write some test codes for this separately?

Can we add a test?

I added a simple test for this. I wanted to add a test including null but when the given value is null, Spark converts it to IsNull. To make this worse, more complicated logics cannot be applied here to test null-safety properly since now filters are pushed down only for basic operations (not even cast or arithmetic calculations). For now, I think this is the best to test this.

test this please

It looks Jenkins does not run the test for the past commits that I made as a user not added to whitelist. Would anybody run the test for this please if it looks good?

test this please

Test build #46425 has finished for PR 8743 at commit bf0b22c.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

Just a question. Now it looks the PR for the end-to-end docker tests is merged. Do you think it needs all the tests for all the databases (namely MySQLIntegrationSuite and PostgresIntegrationSuite for now)?

@zsxwing can you review this one?

@HyukjinKwon +1, I think it'd better to add tests in MySQLIntegrationSuite and PostgresIntegrationSuite.

Hm.. actually I think adding tests more with the docker ingeration tests is a bit over-tested. It looks the comparison operators I used are all already being used in compileFilter and I think the logical operators can be covered in the existing test.

Yes and you're right. We need to clearly define the rule that decides which tests should be added in docker-integration-tests.

I'm wondering if it's okey to add sealed to Filter and remove case _. If so, the compiler can help us find such issue.

@zsxwing I will anyway resolve the conflicts first

Sorry I kept merging pull requests that made your life harder. Can you bring it up to date again? I promise this is the last one.

@rxin Nothing is easy and happy new year:) I just resolved conflicts.

test this please

Test build #2287 has finished for PR 8743 at commit 17b6953.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

test this please

Test build #2291 has finished for PR 8743 at commit a489a33.

• This patch fails PySpark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

Test build #2294 has finished for PR 8743 at commit a489a33.

• This patch fails PySpark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

test this please

Test build #2295 has finished for PR 8743 at commit a489a33.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

Thanks - I've merged this.